Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variant based assignment bug fixes #1194

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

brobro10000
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@brobro10000 brobro10000 marked this pull request as ready for review September 18, 2024 14:46
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (b2a91d6) to head (8881dcc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/components/course/data/utils.jsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
+ Coverage   88.39%   88.41%   +0.02%     
==========================================
  Files         396      396              
  Lines        8407     8408       +1     
  Branches     2061     2065       +4     
==========================================
+ Hits         7431     7434       +3     
+ Misses        933      931       -2     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 5bca07b into master Sep 18, 2024
5 of 6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-variant-bug-bash branch September 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants